kristw commented on a change in pull request #5848: fix sqlab progress bar and 
status inconsistency
URL: 
https://github.com/apache/incubator-superset/pull/5848#discussion_r216495764
 
 

 ##########
 File path: superset/assets/src/SqlLab/components/ResultSet.jsx
 ##########
 @@ -200,7 +200,7 @@ export default class ResultSet extends React.PureComponent 
{
     }
     let progressBar;
     let trackingUrl;
-    if (query.progress > 0 && query.state === 'running') {
+    if (query.progress > 0) {
 
 Review comment:
   Should we hide the progress bar after success?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to