codecov-io commented on issue #5851: remove duplicate utils imported in sql_lab.py URL: https://github.com/apache/incubator-superset/pull/5851#issuecomment-420095058 # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=h1) Report > Merging [#5851](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/73db918fbe0995375b442a1596a402ca27eac9d2?src=pr&el=desc) will **increase** coverage by `13.95%`. > The diff coverage is `71.42%`. [](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5851 +/- ## =========================================== + Coverage 63.75% 77.71% +13.95% =========================================== Files 374 46 -328 Lines 23320 9301 -14019 Branches 2608 0 -2608 =========================================== - Hits 14867 7228 -7639 + Misses 8440 2073 -6367 + Partials 13 0 -13 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [superset/sql\_lab.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | `71.77% <71.42%> (ø)` | :arrow_up: | | [superset/db\_engine\_specs.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzLnB5) | `53.14% <0%> (-2.05%)` | :arrow_down: | | [superset/utils.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMucHk=) | `88.12% <0%> (-0.9%)` | :arrow_down: | | [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `80.37% <0%> (-0.76%)` | :arrow_down: | | [superset/models/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `84.6% <0%> (-0.5%)` | :arrow_down: | | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.03% <0%> (-0.3%)` | :arrow_down: | | [...sets/src/explore/components/ExploreChartHeader.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvRXhwbG9yZUNoYXJ0SGVhZGVyLmpzeA==) | | | | [superset/assets/src/components/Checkbox.jsx](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9jb21wb25lbnRzL0NoZWNrYm94LmpzeA==) | | | | [...perset/assets/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRFbXB0eUxheW91dC5qcw==) | | | | [...ts/src/dashboard/util/getComponentWidthFromDrop.js](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvdXRpbC9nZXRDb21wb25lbnRXaWR0aEZyb21Ecm9wLmpz) | | | | ... and [324 more](https://codecov.io/gh/apache/incubator-superset/pull/5851/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=footer). Last update [73db918...6074009](https://codecov.io/gh/apache/incubator-superset/pull/5851?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
