[GitHub] youngyjd opened a new pull request #5848: fix sqlab progress bar and status inconsistency

[GitBox]

youngyjd opened a new pull request #5848: fix sqlab progress bar and status 
inconsistency
URL: https://github.com/apache/incubator-superset/pull/5848
 
 
   This is an example that progress bar says 100% finished, but status still 
says running
   <img width="1149" alt="screen shot 2018-09-10 at 3 13 56 pm" 
src="https://user-images.githubusercontent.com/26216756/45327380-2af90d00-b50c-11e8-8389-9148d13526f9.png";>
   This is because there is one more round of rendering going on in `sqllab` 
app to show data after it gets the query result. 
   
   In this PR, I introduced one more state regarding query status which is 
`rendering`. After query succeeds, the progress bar will now show `100%` and 
the status will show `rendering`. It is more user friendly. This is what it 
looks like now:
   <img width="1145" alt="screen shot 2018-09-10 at 3 24 01 pm" 
src="https://user-images.githubusercontent.com/26216756/45327734-94c5e680-b50d-11e8-80dc-132fd3083cf8.png";>
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org