minh5 commented on issue #5827: [WIP] Improve column/alias handling for case insensitive engines URL: https://github.com/apache/incubator-superset/pull/5827#issuecomment-420442528 Hey @villebro Got another error this time around ``` 2018-09-11 18:04:30,711:ERROR:root:'tuple' object has no attribute 'lower' Traceback (most recent call last): File "/Users/minhmai/incubator-superset/superset/viz.py", line 385, in get_df_payload df = self.get_df(query_obj) File "/Users/minhmai/incubator-superset/superset/viz.py", line 190, in get_df self.results = self.datasource.query(query_obj) File "/Users/minhmai/incubator-superset/superset/connectors/sqla/models.py", line 813, in query sql, mutated_labels = self.get_query_str(query_obj) File "/Users/minhmai/incubator-superset/superset/connectors/sqla/models.py", line 482, in get_query_str sql = self.database.compile_sqla_query(qry) File "/Users/minhmai/incubator-superset/superset/models/core.py", line 819, in compile_sqla_query compile_kwargs={'literal_binds': True}, File "<string>", line 1, in <lambda> File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/elements.py", line 442, in compile return self._compiler(dialect, bind=bind, **kw) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/elements.py", line 448, in _compiler return dialect.statement_compiler(dialect, self, **kw) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 453, in __init__ Compiled.__init__(self, dialect, statement, **kwargs) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 219, in __init__ self.string = self.process(self.statement, **compile_kwargs) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 245, in process return obj._compiler_dispatch(self, **kwargs) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/visitors.py", line 81, in _compiler_dispatch return meth(self, **kw) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 1785, in visit_select for name, column in select._columns_plus_names File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 1785, in <listcomp> for name, column in select._columns_plus_names File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 1557, in _label_select_column **column_clause_args File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/visitors.py", line 81, in _compiler_dispatch return meth(self, **kw) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 684, in visit_label self.preparer.format_label(label, labelname) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 3089, in format_label return self.quote(name or label.name) File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 3062, in quote if self._requires_quotes(ident): File "/Users/minhmai/.pyenv/versions/3.4.3/envs/superset/lib/python3.4/site-packages/sqlalchemy/sql/compiler.py", line 3033, in _requires_quotes lc_value = value.lower() AttributeError: 'tuple' object has no attribute 'lower' ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
