john-bodley commented on issue #5918: [bugfix] Fixing linting error in macro_tests URL: https://github.com/apache/incubator-superset/pull/5918#issuecomment-422220252 @mistercrunch it seems there may be merit in having this check enabled to prevent the `master` branch from failing the CI checks as people may merge PRs which previously passed CI but would fail if they rebased against `master`.  I realize that this creates some friction, i.e., PR merging becomes a sequential process and the need to rebase (and thus re-run the CI) may slow development, but it seems the safest option for ensuring that we don't have these types of regressions.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
