williaster commented on a change in pull request #5901: Table and dist bar tests
URL:
https://github.com/apache/incubator-superset/pull/5901#discussion_r218615849
##########
File path: superset/assets/cypress/integration/explore/visualizations/table.js
##########
@@ -0,0 +1,92 @@
+import { FORM_DATA_DEFAULTS, NUM_METRIC, SIMPLE_FILTER } from
'./shared.helper';
+
+// Table
+
+describe('Table chart', () => {
+ const VIZ_DEFAULTS = { ...FORM_DATA_DEFAULTS, viz_type: 'table' };
+
+ beforeEach(() => {
+ cy.login();
+ cy.server();
+ cy.route('POST', '/superset/explore_json/**').as('getJson');
+ });
+
+ it('Test table with adhoc metric', function () {
Review comment:
you have a mix of `function () {}` and `() => {}`, most of our tests I think
use the latter / there's no benefit to the former unless you provide a name to
the function for debugging. (`prettier` would also use the latter).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
