michellethomas commented on a change in pull request #5875: [SIP-4] replace
chart ajax calls with `SupersetClient`
URL:
https://github.com/apache/incubator-superset/pull/5875#discussion_r218639753
##########
File path: superset/assets/cypress/utils/readResponseBlob.js
##########
@@ -0,0 +1,11 @@
+// This function returns a promise that resolves to the value
+// of the passed response blob. It assumes the blob should be read as text,
+// and that the response can be parsed as JSON. This is needed to read
+// the value of any fetch-based response.
+export default function readResponseBlob(blob) {
Review comment:
Can you double check cypress doesn't add this in as a test? If you run tests
just make sure this file doesn't show up. I had trouble adding helpers / utils
because it kept picking them up as tests. I'm not sure if it will happen
because this is outside of the integration folder, but if it does I added a
setting to ignore any files with the pattern `*.helper.js`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
