mistercrunch commented on a change in pull request #5790: Linting
URL:
https://github.com/apache/incubator-superset/pull/5790#discussion_r218849499
##########
File path:
superset/assets/spec/javascripts/sqllab/ExploreResultsButton_spec.jsx
##########
@@ -94,20 +94,6 @@ describe('ExploreResultsButton', () => {
expect(wrapper.find(Button)).to.have.length(1);
});
- describe('getColumnFromProps', () => {
- it('should require valid query parameter in props', () => {
- const emptyQuery = {
- database,
- show: true,
- query: {},
- };
- const wrapper = shallow(<ExploreResultsButton {...emptyQuery} />, {
- context: { store },
- }).dive();
- expect(wrapper.state().hints).to.deep.equal([]);
Review comment:
Hints was unused in the component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
