graceguo-supercat edited a comment on issue #5854: [SIP-4] replace dashboard ajax calls with `SupersetClient` URL: https://github.com/apache/incubator-superset/pull/5854#issuecomment-422928030 I do have some concerns for this PR: - It will replace jquery.ajax with a new toolkit (based on fetch, added helper and wrapper) in all Superset.<br/>Is there any existed Superset dependencies that depends on jquery? - This toolkit lives outside Superset codebase. <br/>Given it didn't have any mature customers yet, I feel we (Superset developers) may hit into its bugs or add improvement pretty often. Superset frontend is ajax-heavy. For the long term, when we develop some new features (like improve logging or batch-fetch etc, maybe?), I need to consider should i add this additional function in Superset or in the toolkit code base? <br/>When we need a little change on FAB, I need to fix it in another codebase, tested it in another codebase with many context i am not familiar, wait it build and generate a new version, then i can use it in Superset. This toolkit will be much more friendly than FAB, but the repo is different :) - Is it possible that make the new toolkit inside Superset, but generate standalone modules, to share with embeddable chart? I guess all above are somewhat discussed in the meeting. If all of our major contributors (especially frontend contributors) accept inconvenience, i can accept it too :) @mistercrunch @betodealmeida @hughhhh @xtinec @JamshedRahman @jeffreythewang @fabianmenges @michellethomas @williaster @kristw @conglei
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
