kristw opened a new pull request #5934: ensure npm run build is in production 
mode
URL: https://github.com/apache/incubator-superset/pull/5934
 
 
   Using `--mode=production` does not work with some modules. In particular, 
`react-hot-loader` uses `NODE_ENV` to decide whether to use empty shell or HMR 
code. 
   
   See bundle size before / after this change. 
   
   
![pasted_image_9_19_18__3_39_pm](https://user-images.githubusercontent.com/1659771/45785976-37274d80-bc23-11e8-8db9-7ac6c9169f25.png)
   
   @williaster @xtinec 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to