xtinec commented on issue #5934: Ensure npm run build is in production mode URL: https://github.com/apache/incubator-superset/pull/5934#issuecomment-423025584 @kristw I was thinking something like this in `webpack.config.js`. I'm not 100% sure if it would work, [this](https://github.com/webpack/webpack/issues/6460#issuecomment-364286147) seems to suggest it may. Figured it may be worth a try. 😄 ``` module.exports = (env, argv) => ({ ...etc, plugins: [ ...etc, new webpack.DefinePlugin({ 'process.env.WEBPACK_MODE': JSON.stringify(mode), 'process.env.NODE_ENV': argv.mode })] }); ``` If not, totally cool with leaving as-is. :shipit: 👍
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
