timifasubaa commented on a change in pull request #5940: fix csv upload
schema_name bug
URL:
https://github.com/apache/incubator-superset/pull/5940#discussion_r219069761
##########
File path: superset/db_engine_specs.py
##########
@@ -1005,46 +1005,46 @@ def convert_to_hive_type(col_type):
}
return tableschema_to_hive_types.get(col_type, 'STRING')
+ bucket_path = config['CSV_TO_HIVE_UPLOAD_S3_BUCKET']
+
+ if not bucket_path:
+ logging.info('No upload bucket specified')
+ raise Exception(
+ 'No upload bucket specified. You can specify one in the config
file.')
+
table_name = form.name.data
schema_name = form.schema.data
+ full_table_name = ''
if config.get('UPLOADED_CSV_HIVE_NAMESPACE'):
if '.' in table_name or schema_name:
raise Exception(
"You can't specify a namespace. "
'All tables will be uploaded to the `{}` namespace'.format(
config.get('HIVE_NAMESPACE')))
- table_name = '{}.{}'.format(
+ full_table_name = '{}.{}'.format(
config.get('UPLOADED_CSV_HIVE_NAMESPACE'), table_name)
else:
if '.' in table_name and schema_name:
raise Exception(
"You can't specify a namespace both in the name of the
table "
'and in the schema field. Please remove one')
- if schema_name:
- table_name = '{}.{}'.format(schema_name, table_name)
- filename = form.csv_file.data.filename
- bucket_path = config['CSV_TO_HIVE_UPLOAD_S3_BUCKET']
+ full_table_name = '{}.{}'.format(
+ schema_name, table_name) if schema_name else table_name
- if not bucket_path:
- logging.info('No upload bucket specified')
- raise Exception(
- 'No upload bucket specified. You can specify one in the config
file.')
-
- table_name = form.name.data
filename = form.csv_file.data.filename
- upload_prefix = config['CSV_TO_HIVE_UPLOAD_DIRECTORY']
+ upload_prefix = config['CSV_TO_HIVE_UPLOAD_DIRECTORY']
upload_path = config['UPLOAD_FOLDER'] + \
- secure_filename(form.csv_file.data.filename)
+ secure_filename(filename)
hive_table_schema = Table(upload_path).infer()
column_name_and_type = []
for column_info in hive_table_schema['fields']:
column_name_and_type.append(
'{} {}'.format(
- "'" + column_info['name'] + "'",
+ '`' + column_info['name'] + '`',
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
