mistercrunch commented on a change in pull request #5770: [explore] add "View
samples" modal to action buttons
URL:
https://github.com/apache/incubator-superset/pull/5770#discussion_r219205174
##########
File path: superset/viz.py
##########
@@ -185,6 +185,17 @@ def get_fillna_for_columns(self, columns=None):
}
return fillna
+ def get_samples(self):
Review comment:
Yup that would be database dependent and could be very expansive...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
