mistercrunch commented on a change in pull request #5934: Ensure npm run build
is in production mode
URL:
https://github.com/apache/incubator-superset/pull/5934#discussion_r219255154
##########
File path: superset/assets/package.json
##########
@@ -15,7 +15,7 @@
"dev": "webpack --mode=development --colors --progress --debug --watch",
"dev-server": "webpack-dev-server --mode=development --progress",
"prod": "node --max_old_space_size=4096 webpack --mode=production --colors
--progress",
Review comment:
`prod` is legacy at this point, we use `build`, I don't fully understand the
implications / differences...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
