kristw commented on a change in pull request #5934: Ensure npm run build is in 
production mode
URL: 
https://github.com/apache/incubator-superset/pull/5934#discussion_r219259266
 
 

 ##########
 File path: superset/assets/package.json
 ##########
 @@ -15,7 +15,7 @@
     "dev": "webpack --mode=development --colors --progress --debug --watch",
     "dev-server": "webpack-dev-server --mode=development --progress",
     "prod": "node --max_old_space_size=4096 webpack --mode=production --colors 
--progress",
 
 Review comment:
   I can do whatever you both decide. Please let me know. I don't know what 
`prod` is for, so didn't touch it. 
   
   Thanks @xtinec . Always great to have second eye on. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to