williaster commented on issue #5667: [SIP-4] [Embeddable Charts] Create Superset JS Client URL: https://github.com/apache/incubator-superset/issues/5667#issuecomment-423614852 @graceguo-supercat adding my responses to [your SIP-4 Dashboard refactor comments here](https://github.com/apache/incubator-superset/pull/5854#issuecomment-422928030). > Is there any existed Superset dependencies that depends on jquery? With my series of PRs, the intention is to remove **all** `jQuery` ajax calls. This is one step toward completely removing `jQuery` altogether, which is used in other places for DOM manipulation and possibly `react-bootstrap`. This is a large enough task that doing it in chunks is probably the best way forward. > When we need a little change on FAB, I need to fix it in another codebase, tested it in another codebase with many context i am not familiar, wait it build and generate a new version, then i can use it in Superset. Is it possible that make the new toolkit inside Superset, but generate standalone modules, to share with embeddable chart? Couple thoughts - [Above](https://github.com/apache/incubator-superset/issues/5667#issue-351761915) I enumerated some pros/cons of whether `@superset-ui` packages should live within this repo, or a separate one. The Pros of moving it to a separate repo seemed to outweigh the cons, so we are moving forward with the [separate `superset-ui` repo](https://github.com/apache-superset/superset-ui). - While you're right that it may add some additional overhead to address an issue or develop a feature for `superset` in the separate `superset-ui` repo, this can be largely addressed using `npm link` which simply sym-links package `@superset-ui/xxx` in `node_modules` to your local `@superset-ui/xxx` dev repo. > For the long term, when we develop some new features (like improve logging or batch-fetch etc, maybe?), I need to consider should i add this additional function in Superset or in the toolkit code base? We discussed this in person a bit. To start we'll play it by ear, if something would be useful in another repository, we could make it into a package.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
