villebro commented on issue #5886: Superset ignore case-sensitivity of time column names with Postgresql URL: https://github.com/apache/incubator-superset/issues/5886#issuecomment-423795666 @victornoel Fixing this in a native SQL Alchemy way would require writing something along the lines of `sa.sql.func.DATE_TRUNC(text("'second'"), col)` just to get the expression `DATE_TRUNC('second', col)` when compiling the query. This doesn't look too readable IMO. Not to mention having to change how all other time grains are created in `db_engine_specs` for other engines. Unless this turns out to be a more common problem in other engines, I think your fix is probably the best solution, as forcing quotes around the column names should not have any adverse side effects.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
