williaster commented on a change in pull request #5974: [cypress] add SQL lab
tests
URL:
https://github.com/apache/incubator-superset/pull/5974#discussion_r220644473
##########
File path: superset/assets/cypress/selectors/index.js
##########
@@ -0,0 +1 @@
+export const selectResultsTab = () => cy.get('.SouthPane
.ReactVirtualized__Table');
Review comment:
I thought it could possibly be useful to add a concept of re-usable
`selectors` that are used in multiple tests and select specific elements. The
alternatives would be
- add a cypress command to select that element (seemed too heavy for this
one in particular)
- write the same selector multiple times (this could be fine, if you need to
change them they'd be changed in multiple places)
(`"selector"` was borrowed the word from a common pattern in redux apps to
select specific data from the state tree). totally happy to remove this if you
+ @michellethomas aren't into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
