sylvia-tomiyama commented on issue #4725: Add "Published" feature to dashboards URL: https://github.com/apache/incubator-superset/pull/4725#issuecomment-424831403 thanks for being so thoughtful in iterating with feedback! I think I understand a bit better what you're proposing "publish" does. To confirm, the current behavior/proposal is: #### In welcome page and crud view For admins - show all dashboards regardless of status - show a column that indicates the status of the dashboard (published, draft) For everyone else - show only public dashboards, and dashboards you own - show a column that indicates the status of the dashboard (published, draft) //not sure if this was your intention, but I think this would make sense) #### In profile page - created content tab: show all dashboard you've created, regardless of status //it seems like it would be helpful to know the publication status here, too. like, "oh shit i forgot I was working on these, maybe I should publish them" / sanity check that you haven't published your work-in-progress stuff yet - favorites tab: show favorited dashboards, regardless of publication status #### On dashboard itself For dashboard owner, for an unpublished dashboard - show "draft" label next to title - while in edit mode, you can select "Publish Dashboard" //nit: if we keep this, the D probably shouldn't be capitalized For dashboard owner, for a published dashboard - show nothing next to the title - you can unpublish it For everyone else Unpublished dashboard - show "draft" label next to title - you can favorite it and it will appear in your favorites on your profile page - can't edit status Published dashboard - show nothing - you can favorite it and it will appear in your favorites on your profile page - can't edit status #### Feedback ### I think the "draft" label is a lot clearer than the eye icon. Although I originally suggested putting it in the dropdown, I think @elibrumbaugh has a good point that the corresponding publish action might be too buried in the drop-down and I like the idea of having it as its own separate button. I also think it could work as a toggle (where the indicator is also the button to flip), as long as it's not an eye icon (since we're intentionally making it visible even if it's not published). I think using words is also preferable to icons because then it's easy to map to the statuses that we'd show in the crud/welcome view, and I really like that you can understand the intention of the author of the dashboard as a consumer of a dashboard. I defer to @elibrumbaugh/design though. With regards to terminology, I currently prefer published/draft because I think it feels closer to what the product behavior is. Public/private could be a little ambiguous (does public mean anyone can see it, even outside the company? Also if it were me, if it said private, I would assume that *no one* can view it, and that's not the case (and that's a bad mistake to make)).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
