mistercrunch closed pull request #5959: Explicit set markdown version to >= 3.0
URL: https://github.com/apache/incubator-superset/pull/5959
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/requirements.txt b/requirements.txt
index b076fc0c5a..803007e92b 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -17,7 +17,7 @@ gunicorn==19.8.0
humanize==0.5.1
idna==2.6
isodate==0.6.0
-markdown==2.6.11
+markdown==3.0
pandas==0.23.1
parsedatetime==2.0.0
pathlib2==2.3.0
@@ -39,4 +39,3 @@ thrift-sasl==0.3.0
unicodecsv==0.14.1
unidecode==1.0.22
contextlib2==0.5.5
-
diff --git a/setup.py b/setup.py
index 373ed7e43e..c5dba151a9 100644
--- a/setup.py
+++ b/setup.py
@@ -75,7 +75,7 @@ def get_git_sha():
'humanize',
'idna',
'isodate',
- 'markdown<3.0.0',
+ 'markdown>=3.0',
'pandas>=0.18.0',
'parsedatetime',
'pathlib2',
diff --git a/superset/utils.py b/superset/utils.py
index aa580072e8..636271206d 100644
--- a/superset/utils.py
+++ b/superset/utils.py
@@ -420,7 +420,7 @@ def markdown(s, markup_wrap=False):
'li', 'dd', 'dt', 'img', 'a']
safe_markdown_attrs = {'img': ['src', 'alt', 'title'],
'a': ['href', 'alt', 'title']}
- s = md.markdown(s or '', [
+ s = md.markdown(s or '', extensions=[
'markdown.extensions.tables',
'markdown.extensions.fenced_code',
'markdown.extensions.codehilite',
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
