conglei commented on a change in pull request #5949: [SIP-6] Migrate
visualizations to new directory structure.
URL:
https://github.com/apache/incubator-superset/pull/5949#discussion_r220810731
##########
File path: superset/assets/src/visualizations/FilterBox/transformProps.js
##########
@@ -0,0 +1,39 @@
+export default function transformProps(basicChartInput) {
+ const {
+ datasource,
+ filters,
+ formData,
+ onAddFilter,
+ payload,
+ rawDatasource,
+ } = basicChartInput;
+ const {
+ dateFilter,
+ groupby,
Review comment:
nit. There are some inconsistencies on the name of `groupby`.In some chart,
it is renamed as `groupBy`. it is better to make it consistent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
