kristw commented on a change in pull request #6013: [Sqllab] Add offline state to sqllab URL: https://github.com/apache/incubator-superset/pull/6013#discussion_r224645228
########## File path: superset/assets/src/SqlLab/actions.js ########## @@ -34,6 +34,7 @@ export const SET_DATABASES = 'SET_DATABASES'; export const SET_ACTIVE_QUERY_EDITOR = 'SET_ACTIVE_QUERY_EDITOR'; export const SET_ACTIVE_SOUTHPANE_TAB = 'SET_ACTIVE_SOUTHPANE_TAB'; export const REFRESH_QUERIES = 'REFRESH_QUERIES'; +export const USER_OFFLINE = 'USER_OFFLINE'; Review comment: Rename this to `SET_USER_OFFLINE` to make verb like other action names. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
