williaster commented on a change in pull request #6079: [refactor] Migrate from
Mocha+Chai to Jest
URL:
https://github.com/apache/incubator-superset/pull/6079#discussion_r224859781
##########
File path: superset/assets/spec/javascripts/addSlice/AddSliceContainer_spec.jsx
##########
@@ -19,40 +18,40 @@ describe('AddSliceContainer', () => {
wrapper = shallow(<AddSliceContainer {...defaultProps} />);
});
- it('uses table as default visType', () => {
- expect(wrapper.state().visType).to.equal('table');
+ test('uses table as default visType', () => {
Review comment:
it might be useful to also add the `eslint-plugin-jest` while adding jest
for consistent styles from the start. for example within `describe` blocks it
[recommends using `it` over
`test`](https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md#default-configuration).
(that one is auto-fixable so shouldn't be much work 😄 )
I noticed a mix in the file changes here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
