xtinec commented on a change in pull request #6079: [refactor] Migrate from
Mocha+Chai to Jest
URL:
https://github.com/apache/incubator-superset/pull/6079#discussion_r224866200
##########
File path: superset/assets/spec/helpers/shim.js
##########
@@ -46,9 +45,6 @@ global.XMLHttpRequest = global.window.XMLHttpRequest;
global.sinon = require('sinon');
Review comment:
Totally agree. I didn't do it in the same PR to limit the scope. :) Yeah,
for `sinon`, we need to modify things manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
