mistercrunch commented on a change in pull request #6187: add new db engine
specs for sap hana database
URL:
https://github.com/apache/incubator-superset/pull/6187#discussion_r228414605
##########
File path: superset/db_engine_specs.py
##########
@@ -525,6 +525,10 @@ def convert_dttm(cls, target_type, dttm):
"""TO_TIMESTAMP('{}', 'YYYY-MM-DD"T"HH24:MI:SS.ff6')"""
).format(dttm.isoformat())
+class HanaEngineSpec(BaseEngineSpec):
+ engine = 'hana'
+ utils.DTTM_ALIAS = '"_timestamp"'
Review comment:
Wondering what's you're trying to do here...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
