mistercrunch closed pull request #6209: i18n(App) syntax errors detected by
Grammarly while translating
URL: https://github.com/apache/incubator-superset/pull/6209
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/superset/assets/backendSync.json b/superset/assets/backendSync.json
index 9b825529e9..711496dcd3 100644
--- a/superset/assets/backendSync.json
+++ b/superset/assets/backendSync.json
@@ -37,7 +37,7 @@
null,
null
],
- "description": "Bounds for the Y axis. When left empty, the bounds are
dynamically defined based on the min/max of the data. Note that this feature
will only expand the axis range. It won't narrow the data's extent."
+ "description": "Bounds for the Y-axis. When left empty, the bounds are
dynamically defined based on the min/max of the data. Note that this feature
will only expand the axis range. It won't narrow the data's extent."
},
"order_by_cols": {
"type": "SelectControl",
@@ -253,7 +253,7 @@
]
],
"default": "series",
- "description": "Defines how the color are attributed."
+ "description": "Defines how the colors are attributed."
},
"canvas_image_rendering": {
"type": "SelectControl",
@@ -753,7 +753,7 @@
"label": "Reduce X ticks",
"renderTrigger": true,
"default": false,
- "description": "Reduces the number of X axis ticks to be rendered. If
true, the x axis wont overflow and labels may be missing. If false, a minimum
width will be applied to columns and the width may overflow into an horizontal
scroll."
+ "description": "Reduces the number of X-axis ticks to be rendered. If
true, the x-axis won't overflow and labels may be missing. If false, a minimum
width will be applied to columns and the width may overflow into a horizontal
scroll."
},
"include_series": {
"type": "CheckboxControl",
@@ -834,7 +834,7 @@
"Usa"
]
],
- "description": "The name of country that Superset should display"
+ "description": "The name of the country that Superset should display"
},
"country_fieldtype": {
"type": "SelectControl",
@@ -2242,14 +2242,14 @@
"label": "X bounds",
"renderTrigger": true,
"default": true,
- "description": "Whether to display the min and max values of the X axis"
+ "description": "Whether to display the min and max values of the X-axis"
},
"y_axis_showminmax": {
"type": "CheckboxControl",
"label": "Y bounds",
"renderTrigger": true,
"default": true,
- "description": "Whether to display the min and max values of the Y axis"
+ "description": "Whether to display the min and max values of the Y-axis"
},
"rich_tooltip": {
"type": "CheckboxControl",
@@ -2263,14 +2263,14 @@
"label": "Y Log Scale",
"default": false,
"renderTrigger": true,
- "description": "Use a log scale for the Y axis"
+ "description": "Use a log scale for the Y-axis"
},
"x_log_scale": {
"type": "CheckboxControl",
"label": "X Log Scale",
"default": false,
"renderTrigger": true,
- "description": "Use a log scale for the X axis"
+ "description": "Use a log scale for the X-axis"
},
"log_scale": {
"type": "CheckboxControl",
diff --git a/superset/assets/src/SqlLab/actions.js
b/superset/assets/src/SqlLab/actions.js
index 91e848649c..6d2b6af1a8 100644
--- a/superset/assets/src/SqlLab/actions.js
+++ b/superset/assets/src/SqlLab/actions.js
@@ -287,7 +287,7 @@ export function addTable(query, tableName, schemaName) {
isMetadataLoading: false,
}),
),
- dispatch(addDangerToast(t('Error occurred while fetching table
metadata'))),
+ dispatch(addDangerToast(t('An error occurred while fetching table
metadata'))),
]),
);
@@ -300,7 +300,7 @@ export function addTable(query, tableName, schemaName) {
.catch(() =>
Promise.all([
dispatch(mergeTable({ ...table, isExtraMetadataLoading: false })),
- dispatch(addDangerToast(t('Error occurred while fetching table
metadata'))),
+ dispatch(addDangerToast(t('An error occurred while fetching table
metadata'))),
]),
);
};
diff --git a/superset/assets/src/SqlLab/components/QueryTable.jsx
b/superset/assets/src/SqlLab/components/QueryTable.jsx
index f92d65e8af..9e539636e1 100644
--- a/superset/assets/src/SqlLab/components/QueryTable.jsx
+++ b/superset/assets/src/SqlLab/components/QueryTable.jsx
@@ -173,7 +173,7 @@ class QueryTable extends React.PureComponent {
<Link
className="fa fa-pencil m-r-3"
onClick={this.restoreSql.bind(this, query)}
- tooltip={t('Overwrite text in editor with a query on this
table')}
+ tooltip={t('Overwrite text in the editor with a query on this
table')}
placement="top"
/>
<Link
diff --git a/superset/assets/src/SqlLab/components/TableElement.jsx
b/superset/assets/src/SqlLab/components/TableElement.jsx
index ce6bf68493..96fae9b0b3 100644
--- a/superset/assets/src/SqlLab/components/TableElement.jsx
+++ b/superset/assets/src/SqlLab/components/TableElement.jsx
@@ -143,7 +143,7 @@ class TableElement extends React.PureComponent {
}
text={table.selectStar}
shouldShowText={false}
- tooltipText={t('Copy SELECT statement to clipboard')}
+ tooltipText={t('Copy SELECT statement to the clipboard')}
/>
}
<Link
diff --git a/superset/assets/src/explore/controls.jsx
b/superset/assets/src/explore/controls.jsx
index 442dd4dc64..d3a25a54b2 100644
--- a/superset/assets/src/explore/controls.jsx
+++ b/superset/assets/src/explore/controls.jsx
@@ -223,7 +223,7 @@ export const controls = {
label: t('Y Axis Bounds'),
renderTrigger: true,
default: [null, null],
- description: t('Bounds for the Y axis. When left empty, the bounds are ' +
+ description: t('Bounds for the Y-axis. When left empty, the bounds are ' +
'dynamically defined based on the min/max of the data. Note that ' +
"this feature will only expand the axis range. It won't " +
"narrow the data's extent."),
@@ -485,8 +485,8 @@ export const controls = {
label: t('Reduce X ticks'),
renderTrigger: true,
default: false,
- description: t('Reduces the number of X axis ticks to be rendered. ' +
- 'If true, the x axis wont overflow and labels may be ' +
+ description: t('Reduces the number of X-axis ticks to be rendered. ' +
+ 'If true, the x-axis will not overflow and labels may be ' +
'missing. If false, a minimum width will be applied ' +
'to columns and the width may overflow into an ' +
'horizontal scroll.'),
@@ -534,7 +534,7 @@ export const controls = {
'Usa',
'Zambia',
].map(s => [s, s]),
- description: t('The name of country that Superset should display'),
+ description: t('The name of the country that Superset should display'),
},
country_fieldtype: {
type: 'SelectControl',
@@ -741,7 +741,7 @@ export const controls = {
default: 'auto',
clearable: false,
renderTrigger: true,
- description: t('The way the ticks are laid out on the X axis'),
+ description: t('The way the ticks are laid out on the X-axis'),
},
left_margin: {
@@ -1543,7 +1543,7 @@ export const controls = {
label: t('X bounds'),
renderTrigger: true,
default: false,
- description: t('Whether to display the min and max values of the X axis'),
+ description: t('Whether to display the min and max values of the X-axis'),
},
y_axis_showminmax: {
@@ -1551,7 +1551,7 @@ export const controls = {
label: t('Y bounds'),
renderTrigger: true,
default: false,
- description: t('Whether to display the min and max values of the Y axis'),
+ description: t('Whether to display the min and max values of the Y-axis'),
},
rich_tooltip: {
@@ -1568,7 +1568,7 @@ export const controls = {
label: t('Y Log Scale'),
default: false,
renderTrigger: true,
- description: t('Use a log scale for the Y axis'),
+ description: t('Use a log scale for the Y-axis'),
},
x_log_scale: {
@@ -1576,7 +1576,7 @@ export const controls = {
label: t('X Log Scale'),
default: false,
renderTrigger: true,
- description: t('Use a log scale for the X axis'),
+ description: t('Use a log scale for the X-axis'),
},
log_scale: {
diff --git a/superset/assets/src/explore/visTypes.jsx
b/superset/assets/src/explore/visTypes.jsx
index 0ae0ca56aa..97ac501e83 100644
--- a/superset/assets/src/explore/visTypes.jsx
+++ b/superset/assets/src/explore/visTypes.jsx
@@ -1369,7 +1369,7 @@ export const visTypes = {
},
link_length: {
label: t('No of Bins'),
- description: t('Select number of bins for the histogram'),
+ description: t('Select the number of bins for the histogram'),
default: 5,
},
global_opacity: {
@@ -1816,7 +1816,7 @@ export const visTypes = {
],
},
{
- label: t('Additional meta data'),
+ label: t('Additional metadata'),
controlSetRows: [
['all_columns'],
],
@@ -1837,11 +1837,11 @@ export const visTypes = {
},
row_limit: {
label: t('Event count limit'),
- description: t('The maximum number of events to return, equivalent to
number of rows'),
+ description: t('The maximum number of events to return, equivalent to
the number of rows'),
},
all_columns: {
label: t('Meta data'),
- description: t('Select any columns for meta data inspection'),
+ description: t('Select any columns for metadata inspection'),
},
},
},
diff --git a/superset/connectors/druid/views.py
b/superset/connectors/druid/views.py
index f6b3bb005b..c67e3fcf64 100644
--- a/superset/connectors/druid/views.py
+++ b/superset/connectors/druid/views.py
@@ -121,7 +121,7 @@ class DruidMetricInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
'[Druid Post Aggregation]'
'(http://druid.io/docs/latest/querying/post-aggregations.html)',
True),
- 'is_restricted': _('Whether the access to this metric is restricted '
+ 'is_restricted': _('Whether access to this metric is restricted '
'to certain roles. Only roles with the permission '
"'metric access on XXX (the name of this metric)' "
'are allowed to access this metric'),
diff --git a/superset/connectors/sqla/views.py
b/superset/connectors/sqla/views.py
index e02bde802e..c085958f5b 100644
--- a/superset/connectors/sqla/views.py
+++ b/superset/connectors/sqla/views.py
@@ -108,7 +108,7 @@ class SqlMetricInlineView(CompactCRUDMixin,
SupersetModelView): # noqa
'expression': utils.markdown(
'a valid, *aggregating* SQL expression as supported by the '
'underlying backend. Example: `count(DISTINCT userid)`', True),
- 'is_restricted': _('Whether the access to this metric is restricted '
+ 'is_restricted': _('Whether access to this metric is restricted '
'to certain roles. Only roles with the permission '
"'metric access on XXX (the name of this metric)' "
'are allowed to access this metric'),
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
