jeffreythewang edited a comment on issue #4941: Add separate limit setting for SqlLab URL: https://github.com/apache/incubator-superset/pull/4941#issuecomment-434034249 I've updated this with a working implementation for updating `localStorage`. How I tested: 1. Check out `master` and run SQL Lab to ensure the existing state is properly loaded. 2. Check out this branch and ensure that `defaultQueryLimit` and `maxRow` are loaded. 3. Update backend config values `DEFAULT_SQLLAB_LIMIT`, and `SQL_MAX_ROW` and ensure that they are properly updated on the frontend. @graceguo-supercat I initially tried using `persistState` on creation of the store, but this only seemed to work for updating existing keys already loaded into the store (though this may have been affected by the structure of the object).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
