kristw opened a new pull request #6222: Integrate translation module 
@superset-ui/translation
URL: https://github.com/apache/incubator-superset/pull/6222
 
 
   ### Import `@superset-ui/translation` module
   - Replace calls (in about hundred places) from
   
   ```js
   import { t } from '../locales';
   ```
   
   to
   
   ```js
   import { t } from '@superset-ui/translation'
   ```
   
   ### Update webpack buld config
   
   - Create `preamble.js` which defines the steps that has to happen before 
everything else (e.g. `configure` the translation module)
   - Prepend all webpack entry points with `preamble`. 
   - Replace `common` entry point with `preamble`.
   - Update FAB template (`base.html` and `basic.html`) 
     - Remove `common` entry point from the page that has an entry point 
(because `preamble` is now included with all entry points). 
     - Replace `common` with `preamble` for the page that doesn't have another 
entry point. (`base.html`)
   - Extract `getClientErrorObject` and error message strings into separate 
files. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to