michellethomas opened a new pull request #6223: Fix time range filter dropdown URL: https://github.com/apache/incubator-superset/pull/6223 When on a chart with custom time range, the time range dropdown doesn't open in the custom tab, it always opens in the default tab. I fixed the issue by moving the logic in `componentDidMount` for setting state to `componentWillMount`. While looking into that issue, I noticed another. If you start out on the custom tab and go to the default tab where a radio button has already been set, when you hit OK without clicking another button the filter doesn't get updated correctly. The radio buttons only update the `type` field in state if you click a button, so if the value is already selected, it won't change the type. I fixed it by keeping track of the current tab so in `close()` we can use the common filter if the type has not been set but the tab is default. Here's a video of the second issue (the "Last day" filter doesn't get set correctly):  Fixes #6114
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
