kristw commented on a change in pull request #6236: Dashboard filter box default
URL:
https://github.com/apache/incubator-superset/pull/6236#discussion_r229535812
##########
File path: superset/assets/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -123,7 +123,7 @@ class FilterBox extends React.Component {
label={t('Time range')}
description={t('Select start and end date')}
onChange={(...args) => { this.changeFilter(TIME_RANGE, ...args);
}}
- value={this.state.selectedValues[TIME_RANGE]}
+ value={this.state.selectedValues[TIME_RANGE] || 'No filter'}
Review comment:
Is `No filter` a compatible value for `DateFilterControl`? I haven't run
this but notice the `DateFilterControl` will attempt to parse `value`. Not sure
how it would deal with this.
Just don't want it to become `{since: 'No', until: 'filter' }`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
