xtinec commented on a change in pull request #6220: [SIP-5] Open a new
/api/v1/query endpoint that takes query_obj
URL:
https://github.com/apache/incubator-superset/pull/6220#discussion_r229539378
##########
File path: superset/utils/core.py
##########
@@ -213,6 +213,29 @@ def dttm_from_timtuple(d):
d.tm_year, d.tm_mon, d.tm_mday, d.tm_hour, d.tm_min, d.tm_sec)
+def decode_iso_dttm(o):
Review comment:
We could but we would need to do a second round of parsing on the ISO fields
after doing a naive pass of `json.loads` b/c `json.loads` reads in ISOs as
strings. I'm wondering if it is cleaner to parse things with a custom decoder
like this. 🤔
Relative time expressions will parse as strings here and gets converted to
absolute timestamps when we compute the query object to give to sqlalchemy and
druid (the code for this hasn't been written yet).
Hmm, in theory we could parse timestamps as strings here and add the
conversion logic for both relative and absolute times in a later step. Thoughts?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
