mistercrunch edited a comment on issue #6244: Setting default row_limit to null for timeseries charts URL: https://github.com/apache/incubator-superset/pull/6244#issuecomment-434861400 I think we should put some upper limit as people can crash their browser if they don't. The upper limit should be lower than the number at which we know the browser will crash for sure. This may vary quite a bit based on the viz type, number of series, ... I also think we should allow users to crash their browsers if they want to clear or bump up the limit. They might know something we don't know, have a quantum computer or something. Notice that the label that shows the number or rows in the explore view should turn yellow and warn "you've reached the limit" to make sure users knows that data is missing. We may want to bring more attention to this and have a clear tooltip that explains the tradeoffs.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
