jeffreythewang commented on a change in pull request #6257: Add sql lab
localStorage config
URL:
https://github.com/apache/incubator-superset/pull/6257#discussion_r230146855
##########
File path: superset/assets/src/SqlLab/getInitialState.js
##########
@@ -12,6 +12,7 @@ export default function getInitialState({ defaultDbId,
...restBootstrapData }) {
autorun: false,
dbId: defaultDbId,
};
+ const { common } = restBootstrapData;
return {
sqlLab: {
Review comment:
What if we ever want to add a field here? We'd have to add it outside of
this object (like in `common`), and then store it back in `localStorage` by
adding it somewhere else right (like in `TabbedSqlEditors.jsx`)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
