michellethomas opened a new pull request #6277: Avoid clearing metric when 
saving from datasource editor
URL: https://github.com/apache/incubator-superset/pull/6277
 
 
   Clicking save from the datasource editor would clear your metrics field 
because we were comparing objects in MetricsControl to see if columns or saved 
metrics changed. We should be doing a deep compare.
   
   Thanks @graceguo-supercat for helping track this down!
   
   @mistercrunch @john-bodley @graceguo-supercat 
   
   Fixes #6275

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to