mistercrunch closed pull request #6280: Fix Infinity css warning
URL: https://github.com/apache/incubator-superset/pull/6280
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx
b/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx
index 7e09e73d91..884a54975d 100644
--- a/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx
+++ b/superset/assets/src/dashboard/components/resizable/ResizableContainer.jsx
@@ -7,6 +7,8 @@ import ResizableHandle from './ResizableHandle';
import resizableConfig from '../../util/resizableConfig';
import { GRID_BASE_UNIT, GRID_GUTTER_SIZE } from '../../util/constants';
+const proxyToInfinity = Number.MAX_VALUE;
+
const propTypes = {
id: PropTypes.string.isRequired,
children: PropTypes.node,
@@ -41,9 +43,9 @@ const defaultProps = {
widthMultiple: null,
heightMultiple: null,
minWidthMultiple: 1,
- maxWidthMultiple: Infinity,
+ maxWidthMultiple: proxyToInfinity,
minHeightMultiple: 1,
- maxHeightMultiple: Infinity,
+ maxHeightMultiple: proxyToInfinity,
staticHeight: null,
staticHeightMultiple: null,
staticWidth: null,
diff --git a/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx
b/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx
index 435a541bbc..2c86277407 100644
--- a/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx
+++ b/superset/assets/src/visualizations/deckgl/DeckGLContainer.jsx
@@ -38,7 +38,7 @@ export default class DeckGLContainer extends React.Component {
}));
}
componentWillUnmount() {
- this.clearInterval(this.state.timer);
+ clearInterval(this.state.timer);
}
onViewportChange(viewport) {
const vp = Object.assign({}, viewport);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
