kristw commented on a change in pull request #6283: [dashboard] fix <Loading />
spinners disappear too early
URL:
https://github.com/apache/incubator-superset/pull/6283#discussion_r231027942
##########
File path: superset/assets/src/chart/Chart.jsx
##########
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
>
{this.renderTooltip()}
- {isLoading && <Loading size={50} />}
+ {chartStatus !== 'rendered' && <Loading size={50} />}
Review comment:
How about updating the definition of `isLoading` on line 164?
**from**
```js
const isLoading = chartStatus === 'loading';
```
**to**
```js
const isLoading = chartStatus !== 'rendered';
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
