mistercrunch commented on a change in pull request #6283: [dashboard] fix
<Loading /> spinners disappear too early
URL:
https://github.com/apache/incubator-superset/pull/6283#discussion_r231192702
##########
File path: superset/assets/src/chart/Chart.jsx
##########
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
>
{this.renderTooltip()}
- {isLoading && <Loading size={50} />}
+ {chartStatus !== 'rendered' && <Loading size={50} />}
Review comment:
Variable-naming-wise `isLoading = chartStatus === 'loading'` makes more
sense than `isLoading = chartStatus !== 'rendered'`, so I want to stick with it.
The confusion is more around the component being called `<Loading />` which
should be shown while the component is still either loading (async call) or
rendering (waiting for browser's attention).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
