williaster commented on a change in pull request #6283: [dashboard] fix
<Loading /> spinners disappear too early
URL:
https://github.com/apache/incubator-superset/pull/6283#discussion_r231248295
##########
File path: superset/assets/src/chart/Chart.jsx
##########
@@ -176,7 +176,7 @@ class Chart extends React.PureComponent {
>
{this.renderTooltip()}
- {isLoading && <Loading size={50} />}
+ {chartStatus !== 'rendered' && <Loading size={50} />}
Review comment:
you could possibly add a new variable that makes this more readable `const
showLoader = chartStatus !== 'rendered'`.
This is an interesting observation tho, I think it just shows that the chart
rendering is actually really slow, esp for certain vis types and when you are
loading a dashboard because there are a HUGE amount of DOM changes/additions.
Theoretically the rendering is starting at the same time we were previously
hiding the `Loader` ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
