graceguo-supercat opened a new pull request #6286: [annotation] Only allow override whole time_range URL: https://github.com/apache/incubator-superset/pull/6286 This PR is related with #6251. Before `time_range` we used `since`, `until` parameters. And in annotation layer UI we allow user to override since, or until, or both. But after we introduced `time_range`, it offers many framed time range string like `Last day`, `Last 3 month` etc. in #6251, i tried to merge old since until into time_range, but today we found many corner cases that no simple solution to cover all. So @michellethomas and me are thinking about simplify the override feature in annotation layer: instead of allow since or until or both, now we only allow override time_range as a whole. in airbnb we don't have many cases where user want to override only since or until. if @fabianmenges feel this solution is not good enough, we can think about more possible solutions. @fabianmenges @betodealmeida @mistercrunch @michellethomas
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
