graceguo-supercat commented on a change in pull request #6286: [annotation] 
Only allow override whole time_range
URL: 
https://github.com/apache/incubator-superset/pull/6286#discussion_r231354442
 
 

 ##########
 File path: superset/assets/src/explore/components/controls/AnnotationLayer.jsx
 ##########
 @@ -97,6 +97,14 @@ export default class AnnotationLayer extends 
React.PureComponent {
       timeColumn,
       intervalEndColumn,
     } = props;
+
+    const overridesKeys = Object.keys(overrides);
 
 Review comment:
   render checkbox UI. try to be backward compatible when user select override 
since or override until before.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to