kristw commented on a change in pull request #6294: Wrap <LoadableRenderer />
with <ErrorBoundary />
URL:
https://github.com/apache/incubator-superset/pull/6294#discussion_r231725141
##########
File path: superset/assets/src/components/ErrorBoundary.jsx
##########
@@ -0,0 +1,45 @@
+import React from 'react';
+import PropTypes from 'prop-types';
+import { t } from '@superset-ui/translation';
+import StackTraceMessage from './StackTraceMessage';
+
+const propTypes = {
+ children: PropTypes.node.isRequired,
+ onError: PropTypes.func,
+ showMessage: PropTypes.boolean,
+};
+const defaultProps = {
+ onError: () => {},
+ showMessage: true,
+};
+
+export default class ErrorBoundary extends React.Component {
+ constructor(props) {
+ super(props);
+ this.state = { error: null, info: null };
+ }
+
+ componentDidCatch(error, info) {
+ this.props.onError(error, info);
+ this.setState({ hasError: true, error, info });
Review comment:
Is `hasError` needed? Don't see it being used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
