kristw commented on a change in pull request #6234: [reviewable] Integrate
@superset-ui/{core,color,chart} modules
URL:
https://github.com/apache/incubator-superset/pull/6234#discussion_r231726001
##########
File path: superset/assets/src/explore/controls.jsx
##########
@@ -40,22 +40,23 @@
*/
import React from 'react';
import { t } from '@superset-ui/translation';
+import { getCategoricalSchemeRegistry, getSequentialSchemeRegistry } from
'@superset-ui/color';
+
import {
formatSelectOptionsForRange,
formatSelectOptions,
mainMetric,
} from '../modules/utils';
import * as v from './validators';
-import { PRIMARY_COLOR } from '../modules/colors';
import { defaultViewport } from '../modules/geo';
import ColumnOption from '../components/ColumnOption';
import OptionDescription from '../components/OptionDescription';
-import getCategoricalSchemeRegistry from
'../modules/colors/CategoricalSchemeRegistrySingleton';
-import getSequentialSchemeRegistry from
'../modules/colors/SequentialSchemeRegistrySingleton';
const categoricalSchemeRegistry = getCategoricalSchemeRegistry();
const sequentialSchemeRegistry = getSequentialSchemeRegistry();
+const PRIMARY_COLOR = { r: 0, g: 122, b: 135, a: 1 };
Review comment:
This one is only being used here. A shared filed would be better when the
value is needed across different parts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
