john-bodley commented on a change in pull request #6297: add logging to csv
upload
URL:
https://github.com/apache/incubator-superset/pull/6297#discussion_r231735043
##########
File path: superset/views/core.py
##########
@@ -372,6 +372,7 @@ def form_post(self, form):
flash(
message,
'danger')
+ stats_logger.incr('failed_csv_upload')
Review comment:
Is there merit in including the `sqllab.` prefix? Note I'm not sure whether
historically we use `sqllab` or `sql_lab`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
