kristw commented on a change in pull request #6299: Make stacktraces available
in many more cases
URL:
https://github.com/apache/incubator-superset/pull/6299#discussion_r231780951
##########
File path: superset/assets/src/chart/chartReducer.js
##########
@@ -56,6 +56,7 @@ export default function chartReducer(charts = {}, action) {
[actions.CHART_RENDERING_FAILED](state) {
return { ...state,
chartStatus: 'failed',
+ chartStackTrace: action.stackTrace,
Review comment:
Should `chartStackTrace` be cleared at some point? Otherwise it will be
possible to have `chartStatus=rendered` with stale `chartStackTrace`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
