sujeetpillai commented on pull request #14451: URL: https://github.com/apache/superset/pull/14451#issuecomment-842418115
This change has broken the superset-frontend though for master. configuration_method is not being passed from the database add modal. Works fine for edit since I'm guessing it's loaded from the api but when creating a new one it's giving an error like the attached. <img width="625" alt="Screen Shot 2021-05-17 at 8 55 31 PM" src="https://user-images.githubusercontent.com/1405711/118514628-48b5b000-b752-11eb-9013-c46fbe74716b.png";> My guess is superset-frontend/src/views/CRUD/data/database/types.ts needs to be updated, but I'm not too great at React to be sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
![https://user-images.githubusercontent.com/1405711/118514628-48b5b000-b752-11eb-9013-c46fbe74716b.png"](https://user-images.githubusercontent.com/1405711/118514628-48b5b000-b752-11eb-9013-c46fbe74716b.png"){kind=link}