hughhhh commented on a change in pull request #14673:
URL: https://github.com/apache/superset/pull/14673#discussion_r633899704
##########
File path: tests/db_engine_specs/postgres_tests.py
##########
@@ -430,11 +430,12 @@ def test_base_parameters_mixin():
"port": 5432,
"database": "dbname",
"query": {"foo": "bar"},
+ "encryption": True,
}
sqlalchemy_uri = PostgresEngineSpec.build_sqlalchemy_uri(parameters)
- assert (
- sqlalchemy_uri
- ==
"postgresql+psycopg2://username:password@localhost:5432/dbname?foo=bar"
+ assert sqlalchemy_uri == (
+ "postgresql+psycopg2://username:password@localhost:5432/dbname?"
+ "foo=bar&sslmode=verify-ca"
Review comment:
are there specific types of sslmodes? we could go with an enum approach
if the list is small enough
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
