rusackas commented on a change in pull request #14664:
URL: https://github.com/apache/superset/pull/14664#discussion_r634126907
##########
File path:
superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
##########
@@ -266,6 +266,7 @@ class SliceHeaderControls extends React.PureComponent {
copyMenuItemTitle={t('Copy chart URL')}
emailMenuItemTitle={t('Share chart by email')}
emailSubject={t('Superset chart')}
+ emailBody={t('Check out this chart: ')}
Review comment:
We don't have official copy-writing practices, per se. What we can do in
instances like this one is consider (and potentially approve) the PR, and we
could add the `design-review` label, which means that @mihir174 and/or @steejay
will take a look from a _design_ perspective. If a body of copy gets large
enough or seems contentious, we could take it to the dev@ mailing list for lazy
consensus.
This case seems small enough though that we could just merge it, and if
anyone has better ideas, they can open a new PR to tweak it. This fixes the
bug, in the meantime.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
