kgabryje opened a new pull request #14687: URL: https://github.com/apache/superset/pull/14687
### SUMMARY When a dataset doesn't have any saved metrics, the initial value of Metrics control is empty. There is a warning displayed in chart container, however data panel runs a query anyway. This PR fixes that behaviour - when control panel generates errors, they are passed down to data panel and displayed and no request to backend is sent. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before:  After:  ### TEST PLAN 1. Create a chart using a dataset with no saved metrics. 2. Verify that data panel displays a warning message and doesn't send a request to the backend ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API CC: @junlincc @villebro -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
