villebro opened a new issue #14713:
URL: https://github.com/apache/superset/issues/14713


   ### Expected results
   
   When setting a default value to a select filter and clearing it, the 
`extraFormData` isn't cleared. This is happening because AntD form isn't able 
to set a nested object to empty, but rather leaves the old one in place. See a 
related discussion here: 
https://github.com/ant-design/ant-design/issues/8806#issuecomment-379543118
   
   what you expected to happen.
   
   ### Actual results
   
   what actually happens.
   
   #### Screenshots
   
   If applicable, add screenshots to help explain your problem.
   
   #### How to reproduce the bug
   
   Add a default value:
   
![image](https://user-images.githubusercontent.com/33317356/118826590-4a06ea00-b8c4-11eb-8b8c-d3b66ffdbb44.png)
   
   Remove default value:
   
![image](https://user-images.githubusercontent.com/33317356/118826544-3eb3be80-b8c4-11eb-9610-b05e40f3fe5c.png)
   
   When going back to the dashboard, notice how the filter state is empty, but 
it's trying to apply `extraFormData` to charts:
   
![image](https://user-images.githubusercontent.com/33317356/118826676-5c812380-b8c4-11eb-8d70-521e2087ee08.png)
   
   Check Redux and see, that `extraFormData` was not reset to an empty object, 
despite having been updated by `setDataMask`:
   
![image](https://user-images.githubusercontent.com/33317356/118826399-23e14a00-b8c4-11eb-82d7-09ffe1f20559.png)
   
   ### Checklist
   
   Make sure to follow these steps before submitting your issue - thank you!
   
   - [ ] I have checked the superset logs for python stacktraces and included 
it here as text if there are any.
   - [ ] I have reproduced the issue with at least the latest released version 
of superset.
   - [ ] I have checked the issue tracker for the same issue and I haven't 
found one similar.
   
   ### Additional context
   
   Add any other context about the problem here.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to