suddjian opened a new pull request #14722: URL: https://github.com/apache/superset/pull/14722
### SUMMARY <!--- Describe the change below, including rationale and design decisions --> When the feature flag `SQLLAB_BACKEND_PERSISTENCE` is set to False, user data is currently saved in local storage. A recent change added roles information to the bootstrap user object. But with the flag off, local storage data ends up overwriting the bootstrap data, and the roles are lost. This change removes user data from local storage, and prevents it from overwriting the bootstrap data. ### TEST PLAN <!--- What steps should be taken to verify the changes --> - Turn the flag off - checkout a commit from before [a7a011cce5ea9a9ae6cebf40b6e5bc6257d7746d](https://github.com/apache/superset/commit/a7a011cce5ea9a9ae6cebf40b6e5bc6257d7746d) - visit sql lab, execute a query (loads your user into localstorage) - checkout this fix - visit sql lab (user is removed from localstorage and page should show up) ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
